test: only include required networks for e2e tests #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…e into fix-e2e-ci-no-list
…e into fix-e2e-ci-no-list
…e into fix-e2e-ci-no-list
…e into fix-e2e-ci-no-list
…e into fix-e2e-ci-no-list
dewanshparashar
changed the title
dewanshparashar
changed the title
brtkx
previously approved these changes
Dec 27, 2024
…e into fix-e2e-ci-no-list
spsjvc
reviewed
Jan 10, 2025
| @@ -16,5 +16,8 @@ export function shortenTxHash(txHash: string) { | |||
| )}` | |||
| } | |||
|
|
|||
| export const isE2eTestingEnvironment = | |||
| typeof window !== 'undefined' && !!window.Cypress | |||
|
|
|||
| export const isTestingEnvironment = | |||
There was a problem hiding this comment.
There's 2 places where we use isTestingEnvironment:
- in
ProjectListing.tsxto display some dummy data - in
setup.tsto configure chains
I think what we really need is isDevelopmentEnvironment because both of these use cases really depend on that. Having both isE2eTestingEnvironment and isTestingEnvironment is confusing.
There was a problem hiding this comment.
Ah, good name isDevelopmentEnvironment ! Even I felt having isE2eTestingEnvironment and isTestingEnvironment was not optimal but couldn't come up with the perfect naming. Ty!
spsjvc
approved these changes
Jan 14, 2025
spsjvc
changed the title
brtkx
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-1070